Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for Firefox browser compatibility #707

Merged
merged 22 commits into from
Dec 2, 2024
Merged

feat: add support for Firefox browser compatibility #707

merged 22 commits into from
Dec 2, 2024

Conversation

Tverous
Copy link

@Tverous Tverous commented Nov 2, 2024 •
edited
Loading

Desc

Resolving #61

Extend browser compatibility to support Firefox as an alternative to Chrome.

To specify the browser type explicitly, use the --browser firefox option when running main.py.

@surapuramakhil surapuramakhil self-requested a review November 2, 2024 17:05
@surapuramakhil surapuramakhil changed the base branch from main to release/v11.15.2024 November 2, 2024 17:07
surapuramakhil
surapuramakhil suggested changes Nov 2, 2024
View reviewed changes
Copy link
Contributor

@surapuramakhil surapuramakhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if possible, can you create a file for selenium interactions. Ensure selenium methods works for both browsers.

def is_scrollable(element):

def scroll_slow(driver, scrollable_element, start=0, end=3600, step=300, reverse=False):

main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
src/utils.py Outdated Show resolved Hide resolved
src/utils.py Outdated Show resolved Hide resolved
@surapuramakhil surapuramakhil added the enhancement New feature or request label Nov 2, 2024
@surapuramakhil
Copy link
Contributor

surapuramakhil commented Nov 2, 2024 •
edited
Loading

@Tverous can make any comment on issue 61, we can assign this issue to you.

@Tverous
Copy link
Author

Tverous commented Nov 5, 2024 •
edited
Loading

@surapuramakhil, would you mind reviewing for the refactored code? Thanks!

@feder-cr
Copy link
Collaborator

feder-cr commented Nov 7, 2024

@surapuramakhil

@feder-cr feder-cr requested review from sarob, cjbbb and feder-cr November 7, 2024 00:32
@sarob
Copy link
Collaborator

sarob commented Nov 7, 2024

I will wait to review until after @surapuramakhil requested changes and the conflicts are resolved.

@Tverous
Copy link
Author

Tverous commented Nov 7, 2024 •
edited
Loading

@surapuramakhil, let me know if you want me to resolve the conflict or add more descriptions of the refactored code first. thanks.

@feder-cr
Copy link
Collaborator

feder-cr commented Nov 8, 2024

@Tverous resolve the conflicts

@Tverous
Copy link
Author

Tverous commented Nov 8, 2024

conflicts resolved

@feder-cr
Copy link
Collaborator

feder-cr commented Nov 8, 2024

@sarob please can you do a review?

@surapuramakhil
Copy link
Contributor

@surapuramakhil, let me know if you want me to resolve the conflict or add more descriptions of the refactored code first. thanks.

yes, Kindly resolve confits. Without that we won't be able to merge it into the release branch.

join discord release channel: https://discord.gg/gjDwqhXZ52

@surapuramakhil
Copy link
Contributor

passing this PR to @sarob

surapuramakhil
surapuramakhil suggested changes Nov 12, 2024
View reviewed changes
main.py Outdated Show resolved Hide resolved
src/webdrivers/browser_factory.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
src/webdrivers/browser_factory.py Outdated Show resolved Hide resolved
@feder-cr
Copy link
Collaborator

Totally agree with @surapuramakhil comment.

@Tverous let me know what do you think

@surapuramakhil surapuramakhil changed the base branch from release/v11.15.2024 to release/v3.1.0 November 14, 2024 19:43
surapuramakhil
surapuramakhil suggested changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@surapuramakhil surapuramakhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one change is required. Single source of truth one.

@surapuramakhil
Copy link
Contributor

@Tverous this PR is waiting for this

https://github.com/AIHawk-FOSS/Auto_Jobs_Applier_AI_Agent/pull/707/files/03f387f32256d2fa32d407f892c29a45e09e0665#r1846776050

@surapuramakhil surapuramakhil linked an issue Nov 21, 2024 that may be closed by this pull request
Add support for Firefox #61
Open
@feder-cr
Copy link
Collaborator

@Tverous any updates?

@surapuramakhil
Copy link
Contributor

@Tverous any updates?

based on this https://github.com/AIHawk-FOSS/Auto_Jobs_Applier_AI_Agent/pull/707/files/03f387f32256d2fa32d407f892c29a45e09e0665#r1849167202

It looks like a senior dev needs to contribute to remove the current cyclic dependency.

@feder-cr
Copy link
Collaborator

@surapuramakhil ok

@feder-cr feder-cr closed this Dec 2, 2024
@surapuramakhil surapuramakhil reopened this Dec 2, 2024
@surapuramakhil surapuramakhil self-assigned this Dec 2, 2024
@surapuramakhil surapuramakhil added this to the release-v2024.12.06 milestone Dec 2, 2024
surapuramakhil
surapuramakhil previously approved these changes Dec 2, 2024
View reviewed changes
src/webdrivers/browser_factory.py Outdated Show resolved Hide resolved
@surapuramakhil surapuramakhil removed the request for review from sarob December 2, 2024 22:12
surapuramakhil
surapuramakhil previously approved these changes Dec 2, 2024
View reviewed changes
@surapuramakhil surapuramakhil merged commit f1b88f6 into AIHawk-FOSS:release/v4.1.0 Dec 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surapuramakhil surapuramakhil surapuramakhil approved these changes

Assignees

@surapuramakhil surapuramakhil

@Tverous Tverous

Labels
enhancement New feature or request
Projects
Auto Job Applier
Status: In Release branch
Milestone
release-v2024.12.06
Development

Successfully merging this pull request may close these issues.

Add support for Firefox
4 participants
@Tverous @surapuramakhil @feder-cr @sarob